Skip to content

Conversation

@github-roushan
Copy link
Contributor

Describe Your Changes

  • Add preflight option to get metadata and actionable errors
  • Add Token Validation Timeout
  • Improve Various Toasts for download action
  • Improve validate button ux

Fixes Issues

Self Checklist

  • Added relevant comments, esp in complex areas
  • Updated docs (for bug fixes / features)
  • Created issues for follow-up changes or refactoring needed

- Add preflight option to get metadata and actionable errors
- Add Token Validation Timeout
- Improve Various Toasts for download action
- Improve validate button ux
@github-roushan
Copy link
Contributor Author

@louis-jan

@Vanalite
Copy link
Contributor

@github-roushan can you share some screenshots for us to grasp the idea how this fixes?

@github-roushan
Copy link
Contributor Author

github-roushan commented Nov 19, 2025

Screencast.from.2025-11-19.11-26-22.webm

Here @Vanalite

@github-roushan
Copy link
Contributor Author

@Vanalite. To add more context. the status code is captured and passed around giving more context on what has happened and for this issue we add a toast with redirection to add the key in settings.

@github-roushan
Copy link
Contributor Author

@Vanalite. Do you need anything else?

@Vanalite
Copy link
Contributor

@github-roushan Pretty cool! But the validation button seems off with other designs. Now only HF has token validation while the others don't. I would recommend to not have the validation button there but let the general error message yields out similarly to how invalid token behaves on other remote providers

@github-roushan
Copy link
Contributor Author

@Vanalite . Will remove the button. or i can add the button to everyother place. let me know,what is your design guideline

@Vanalite
Copy link
Contributor

Vanalite commented Nov 20, 2025

@Vanalite . Will remove the button. or i can add the button to everyother place. let me know,what is your design guideline

We're now embrace the simplicity. Since we only have a check ✅ icon (e.g import model), you can apply it to the validation. I'm not sure if you can mass apply the validation to all remote providers. In case it's causing trouble, remove the button would be fine

@github-roushan
Copy link
Contributor Author

@github-roushan Pretty cool! But the validation button seems off with other designs. Now only HF has token validation while the others don't. I would recommend to not have the validation button there but let the general error message yields out similarly to how invalid token behaves on other remote providers

I believe keeping the validation button is the better approach.
It gives users explicit control over when to authorize their key, rather than relying solely on implicit checks or downstream errors.

To improve the UX, I've ensured there is a timeout mechanism (10 seconds). This handles cases where Hugging Face might be slow or unresponsive—if validation hangs, the button will reset, allowing the user to retry easily.

I plan to extend this pattern to other providers for consistency. But for now this looks good

@github-roushan
Copy link
Contributor Author

@Vanalite

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

bug: model hub downloads error 401

2 participants