-
Notifications
You must be signed in to change notification settings - Fork 2.4k
feat: Improve toast messages and errors #6892
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Conversation
- Add preflight option to get metadata and actionable errors - Add Token Validation Timeout - Improve Various Toasts for download action - Improve validate button ux
dc630fa to
958ad06
Compare
|
@github-roushan can you share some screenshots for us to grasp the idea how this fixes? |
Screencast.from.2025-11-19.11-26-22.webmHere @Vanalite |
|
@Vanalite. To add more context. the status code is captured and passed around giving more context on what has happened and for this issue we add a toast with redirection to add the key in settings. |
|
@Vanalite. Do you need anything else? |
|
@github-roushan Pretty cool! But the validation button seems off with other designs. Now only HF has token validation while the others don't. I would recommend to not have the validation button there but let the general error message yields out similarly to how invalid token behaves on other remote providers |
|
@Vanalite . Will remove the button. or i can add the button to everyother place. let me know,what is your design guideline |
We're now embrace the simplicity. Since we only have a check ✅ icon (e.g import model), you can apply it to the validation. I'm not sure if you can mass apply the validation to all remote providers. In case it's causing trouble, remove the button would be fine |
I believe keeping the validation button is the better approach. To improve the UX, I've ensured there is a timeout mechanism (10 seconds). This handles cases where Hugging Face might be slow or unresponsive—if validation hangs, the button will reset, allowing the user to retry easily. I plan to extend this pattern to other providers for consistency. But for now this looks good |
59e3f74 to
4deaa6a
Compare
Describe Your Changes
Fixes Issues
Self Checklist